Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/tanlang/filtrate deal by deal state before assigned #202

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Feat/tanlang/filtrate deal by deal state before assigned #202

merged 3 commits into from
Sep 23, 2022

Conversation

LinZexiao
Copy link
Collaborator

@LinZexiao LinZexiao commented Sep 21, 2022 •
edited
Loading

关联的Issues (Related Issues)

close filecoin-project/venus#5312

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前，需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@LinZexiao LinZexiao force-pushed the feat/tanlang/filtrate-deal-by-deal-state-before-assigned branch from 7f4a8d3 to ecb259b Compare September 21, 2022 09:02
@LinZexiao LinZexiao self-assigned this Sep 21, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #202 (ecb259b) into master (0b20156) will decrease coverage by 0.13%.
The diff coverage is 91.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   24.78%   24.65%   -0.14%     
==========================================
  Files         176      177       +1     
  Lines       18671    18815     +144     
==========================================
+ Hits         4627     4638      +11     
- Misses      13480    13613     +133     
  Partials      564      564
Flag Coverage Δ
unittests 24.65% <91.66%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
models/repo/repo.go 100.00% <ø> (ø)
storageprovider/deal_assigner.go 0.00% <0.00%> (ø)
models/badger/storage_deal.go 70.11% <100.00%> (-2.73%) ⬇️
models/mysql/storage_deal.go 68.75% <100.00%> (+0.24%) ⬆️
blockstore/badger/blockstore.go 55.90% <0.00%> (-0.46%) ⬇️
cmd/venus-market/main.go 0.00% <0.00%> (ø)
cli/stats.go 0.00% <0.00%> (ø)
paychmgr/simple.go 80.49% <0.00%> (+1.13%) ⬆️

@LinZexiao LinZexiao force-pushed the feat/tanlang/filtrate-deal-by-deal-state-before-assigned branch from ecb259b to d2115b7 Compare September 23, 2022 07:31
simlecode
simlecode approved these changes Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

@simlecode simlecode merged commit 9de30ab into master Sep 23, 2022
@simlecode simlecode deleted the feat/tanlang/filtrate-deal-by-deal-state-before-assigned branch September 23, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simlecode simlecode simlecode approved these changes

@hunjixin hunjixin Awaiting requested review from hunjixin

Assignees

@LinZexiao LinZexiao

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@LinZexiao @codecov-commenter @simlecode